buildingSMART / bSDD

The buildingSMART Data Dictionary repository, where we publish the documentation, examples and more. We don't publish here the data, the source code of the bSDD service or the front end of the website.
https://www.buildingsmart.org/users/services/buildingsmart-data-dictionary/
MIT License
129 stars 36 forks source link

"Old" domain URI leads to error 400 for endpoint api/Domain/v*/Classifications #66

Closed araccaine closed 1 year ago

araccaine commented 1 year ago

Describe the bug

It seems that since a few days the URI format for domains has changed from <domain_name>-<domain_version> to <domain_name>/<domain_version> (slash instead of hyphen). (This seems to be indicated e.g. in PR #65)

The API now returns error 400 for endpoint api/Domain/v*/Classifications (both v2 and v3) when using the "old" format with a hyphen.

To Reproduce

  1. Example URI: https://identifier.buildingsmart.org/uri/molio/cciconstruction-1.0
  2. Use this URI for api/Domain/v2/Classifications: https://api.bsdd.buildingsmart.org/api/Domain/v2/Classifications?namespaceUri=https%3A%2F%2Fidentifier.buildingsmart.org%2Furi%2Fmolio%2Fcciconstruction-1.0&useNestedClassifications=false
  3. Response:

    "Domain with namespace \u0027https://identifier.buildingsmart.org/uri/molio/cciconstruction-1.0\u0027 not found"

Expected behaviour

Other endpoints automatically convert the URI into the "new" format, e.g. api/Classification/v4.

Example:

Baars-IT commented 1 year ago

Thanks for letting us know and providing detailed information! It is indeed the intention to supply automatic conversion from old URIs to new URIs on all endpoints.

It is now fixed for endpoints [api/Domain/v*/Classifications].

Note that supporting old formats will be removed in the future (not sure when, but at least 6 months from now). Keep an eye on our forum for tech updates: https://forums.buildingsmart.org/t/bsdd-tech-updates/4889