IVS-84/Fix - PSE001 stricter prefix matching

[Ghesselink]

The rule has been made stricter to ensure that incorrect property set names now trigger the rule and produce an error. Previously, this activation was not case-sensitive, leading to false positives with the following examples:

• pset_Wallcommon
• PSET_Wallcommon

For the property set Pset Wallcommon, the rule still activates and results in an error as intended.

Additionally:

• An option has been added to check for literal values, allowing a rule to be activated or validated with the same statement. This does not apply to the current rule, where we want activation to be broad while ensuring validation is case-sensitive.
• Several test files have been added to verify these changes.

[aothms]

Everything is working as anticipated but the Expected message does not provide any clue that the failure is caused by PSET_ at the beginning of the Name attribute instead of Pset. Is there a way to inject that in the Expected field?

Agreed.

• I also find the feature text maybe not as explicit as could be. Instead of with or without literally we could also consider in a case sensitive manner / insensiitive . To make it a bit more explicit. Maybe that already helps a bit pointing the user to the PSET/Pset distinction.
• It's also a little bit 'strange' that we're going to be trying to match "PSET something" to "{Pset_WallCommon", ...} now because we already know that every we're not going to find anything if it's not Pset_... verbatimly.

These things combined, I could also imagine we write a new scenario specifically around this:

Given its Name attribute starts with "pset" in a case insensitive manner
Then its Name attribute starts with "Pset_" in a case sensitive manner

[Ghesselink]

Sounds good, as you suggested before

 Pset_* -> error
[pP][sS][eE][tT]* -> warning

We would be able to make sensitive part for errors and the insensitive for warnings, maybe with the tags.

So for example

@E00020 #Error
Scenario : Case sensitive validation for errors 
Given An IfcPropertySet
Given its Name attribute starts with "pset" in a case insensitive manner
Given its Name attribute starts with "Pset_" in a case sensitive manner
Then The IfcPropertySet Name attribute value must use predefined values according to the "pset_definitions" table #e.g.

@W00030 #Warning
Scenario: Case insensitive validation for warnings
Given an IfcPropertySet
Given its Name attribute starts with "pset" in a case insensitive manner
Given its Name attribute does not start with "Pset_" in a case sensitive manner #don't trigger both error and warning
Then The IfcPropertySet Name attribute value must use predefined values according to the "pset_definitions" table #e.g.

To-do's would then be

• Structure the feature file differently (it's not possible to use two Backgrounds in the same feature file).
• Ensure scenario-tags scenario overwrite feature-wide tags (i.e. @industry-practice / @implementer-agreement) on frontend.
• While we're add it, give the python implementation a good cleanup. Possibly in different functions or statements; it's a bit difficult to read.