buildingSMART / ifc-gherkin-rules

MIT License
9 stars 18 forks source link

IVS-77 - Always include at least one Validation Outcome #273

Closed Ghesselink closed 3 weeks ago

Ghesselink commented 3 weeks ago

We currently have two mechanisms to prevent Behave from executing subsequent steps:

However, the platform does not display a rule if:

This is not the desired behavior. Instead, we should always log a ValidationOutcome with a status of "NotApplicable." Since the platform searches for the maximum severity, adding this outcome will not affect other results negatively. This ensures that all rules are displayed for every uploaded file.

aothms commented 3 weeks ago

Ok, hurray we litterally just opened the same PR https://github.com/buildingSMART/ifc-gherkin-rules/pull/272 Good that we agree!

aothms commented 3 weeks ago

Duplicate of #272