buildingSMART / ifc-gherkin-rules

MIT License
11 stars 18 forks source link

IVS-131 - Issue #279 - IFC102 improvements & cleanup validation_handling #282

Closed Ghesselink closed 2 months ago

Ghesselink commented 2 months ago

Addresses https://github.com/buildingSMART/ifc-gherkin-rules/issues/279

We should probably also do this for attributes of entities (?). For this, there's a new small decorator to register enumeration types. Using this is quite intuitive; simply decorate the Enum-inherited class with @register_enum_type),. There is probably no need to use TypeBuilder (correct me if I'm wrong)

Furthermore, a testfile is added to ensure IfcTextLiteralWithExtent is passing.

Ghesselink commented 2 months ago

Another nuance I was not aware of .. Thanks :) I'm assuming the same is true for IfcStyleAssignmentSelect, they're both deleted from the deprecated list.

We're now checking for exact types for deprecated entities. Just to be sure, I think this doesn't apply for the deprecated attributes of entities? To give an example, for IfcRelAssigns, the RelatedObjectsType attribute is deprecated. This will then also be the case for its subtypes; IfcRelAssignsToActor, RelAssignsToGroup, and so forth. The same applies to IfcReinforcingElement -> IfcReinforcingBar, Mesh, Anchor, Conduit and IfcTendon,

aothms commented 2 months ago

To give an example, for IfcRelAssigns, the RelatedObjectsType attribute is deprecated. This will then also be the case for its subtypes; IfcRelAssignsToActor, RelAssignsToGroup, and so forth. The same applies to IfcReinforcingElement -> IfcReinforcingBar, Mesh, Anchor, Conduit and IfcTendon,

Correct!