search

buildingblocks / grunt-combine-media-queries

[DEPRECATED] A new version is managed here: https://github.com/frontendfriends/grunt-combine-mq
MIT License
293 stars 17 forks source link

Move core to separate module/repo #20

Closed thomasdobber closed 7 years ago

thomasdobber commented 10 years ago

This plugin should only be a wrapper for Grunt. When we wrote grunt-combine-media-queries at the time I didn't realise this. I've been thinking about moving this thing to gulp (since that is my tool of choice now), but by moving the core to a separate module it can easily be used for e.g. Rework as well and it would be much easier to keep it up to date everywhere.

I will create an NPM module from the dev branch in a separate repo and start testing it.

I saw that somebody used our code to create a gulp plugin already and this is where the trouble begins...

spacedawwwg commented 10 years ago

I think we could start up a completely separate repo for this new module.

combinemq, grunt-combinemq, gulp-combinemq

This way we can completely start afresh but allow people using the current grunt plugin to continue doing so.

What do you think?

Have you looked at postcss at all? I was hoping to try it out instead of css-parse. On Mar 12, 2014 6:08 PM, "Thomas Dobber" notifications@github.com wrote:

This plugin should only be a wrapper for Grunt. When we wrote grunt-combine-media-queries at the time I didn't realise this. I've been thinking about moving this thing to gulp (since that is my tool of choice now), but by moving the core to a separate module it can easily be used for e.g. Rework as well and it would be much easier to keep it up to date everywhere.

I will create an NPM module from the dev branch in a separate repo and start testing it.

I saw that somebody used our code to create a gulp plugin already and this is where the trouble begins...

Reply to this email directly or view it on GitHubhttps://github.com/buildingblocks/grunt-combine-media-queries/issues/20 .

thomasdobber commented 10 years ago

Sorry Paul, I totally misread your comment!

I've been looking into both postcss and node-css-mqpacker and came to the conclusion that postcss is awesome(!) and that mqpacker does exactly the same as grunt-combine-media-queries minus the ordering.

I suggest we open an issue on mqpacker and offer our help on improving it and if it turns out that they have no interest in such a function we can always start over.

What do you think?

Ps. either way I have a couple of ideas for new modules that I would love to discuss with you guys if you are interested.