search

buildingfirefoxos / Building-Blocks

Reusable components for Firefox OS
Other
292 stars 97 forks source link

Fixed syntax error #18

Closed DerekRoth closed 10 years ago

DerekRoth commented 10 years ago

Honestly i don't know the impact of this, but i noticed an error in my console log coming from this line. Before this commit, this line was just ignored by Firefox.

gasolin commented 10 years ago

good catch!

We'd generally sync Building-blocks from gaia repository, and use bugzilla to track issue fixing thing.

Would you mind send a pull request to gaia https://github.com/mozilla-b2g/gaia , and post your pull request to

https://bugzilla.mozilla.org/show_bug.cgi?id=959443

the BB is located in gaia/shared/style/icon.css

I can help you complete the process, would you like to try?

DerekRoth commented 10 years ago

Well i actually looked at the gaia repository but could not find this file. Maybe did it move to another place, or am i not looking at the good branch ?

gasolin commented 10 years ago

Ooh you are right, it's BB only.

Thank you for fix it!