search

buildingsmart-community / bSDD-Revit-plugin

MIT License
30 stars 2 forks source link

IFC classification check doesn't see mappingtable #69

Open Rien777 opened 6 months ago

Rien777 commented 6 months ago

Describe the issue: The IFC classification displayes Red when not set in the 'Export Type to IFC As' parameter.

Steps to reproduce the behavior: Select any element without an export-type set.

Expected behavior: It should check the IFC export mapping table and check that value in the UI backend.

Possible solution: Discussion on 2 possible solutions:

  1. Make IFC special and not a classification (it has its own values in the ifcjson aswell)
  2. If it stays an classification, when collecting classifications from the datastorage settings, for IFC also check the mapping table (and not just the bsdd param and the mapped param): image
Rien777 commented 6 months ago

@janbrouwer @ebouwens thoughts on this issue?

janbrouwer commented 6 months ago

I think it depends on if Revit keeps track of which IFC version is used in the parameters (which I believe is not) then the application side can be separated because buildingSMART also doesn't want IFC added as an additional IfcClassification. On the other hand, in SketchUp the IFC version IS stored in the objects.