search

buildingu / Building-u-feedback

A feedback application that allows the interns at building-u, receive feedbacks on their projects.
https://buildingu.github.io/Building-u-feedback/
0 stars 5 forks source link

Added Password Strength validation #51

Closed tanvir-shaikh closed 3 months ago

tanvir-shaikh commented 3 months ago

i have added the password validation as per acceptance Criteria. kept it simple no fancy meter & stuff. i suggest we should tell user what are the acceptance criteria, that's why i have added a 1 line description, it'll be better if it's like

Must include min 12 - max 32 chars, 1 uppercase letter, 1 number and 1 special char. but that will make it 2 lines.

also i think using PasswordInput component rather than TextInput will be better as we get eye to toggle it in plain text will be helpful to see password when users misses acceptance criteria.

gbudjeakp commented 3 months ago

@tanvir-shaikh Mind going to the issues page of this PR and commenting that you want to work on it?