search

buildinspace / peru

a generic package manager, for including other people's code in your projects
MIT License
1.12k stars 69 forks source link

Mention requirements more clearly in README #224

Closed colindean closed 2 years ago

colindean commented 2 years ago

I've nearly always had git available anywhere I was using Peru but found while setting up a new CI pipeline that Peru calls git via subprocess for caching.

This dependency is undeclared in the Homebrew formula but is declared in the AUR package. I'll update the Homebrew formula.

colindean commented 2 years ago

Opened https://github.com/Homebrew/homebrew-core/pull/95810

oconnor663 commented 2 years ago

The first paragraph of the "Installation" section mentions this requirement. Do you think we should clarify it?

colindean commented 2 years ago

Yes. I missed it and Homebrew missed it although whoever wrote The Homebrew formula may have simply assumed that whatever git Homebrew is relying on was adequate and didn't need to be an explicit dependency.

Minimally, I think it's worth clarifying that it's needed even if you're not pulling from a git repository.

colindean commented 2 years ago

I need to resolve the conflicts created by my other PR getting merged so I'll revisit this I'm going to finish brewing my coffee.

colindean commented 2 years ago

Fixed and ready for review. I chose to list the requirements and then call it out again in the pip section in case someone looks it up fast and misses the previous list.

colindean commented 2 years ago

This is ready!

colindean commented 2 years ago

This is ready!

oconnor663 commented 2 years ago

Thank you! Sorry for dropping the ball on this one.