buildium / generator-angular-browserify

Yeoman generator for Angular 1.x components, and full apps.
2 stars 1 forks source link

Integrate Buildium eslint #2

Open mndewitt opened 8 years ago

mndewitt commented 8 years ago

It would be great to run the Buildium eslint config on these template to make sure they pass. I got as far as:

-Adding gulp -Adding eslint

The main issue is that the EJS syntax in the templates causes eslint to fail. I'm wondering if there is a way around this. There is also some work to do to integrate the Buildium eslint config into this project.

Looking for help with part or all of the following tasks:

-Add a build tool (we think npm scripts would work well for this) and add eslint -Integrate the buildium eslint plugin and config to the project -Automating the checks in a git hook :)

jbalboni commented 8 years ago

For other OSS projects, we've so far used npm scripts instead of gulp or grunt. That might be an option if whatever "build" we need to do stays simple.

mndewitt commented 8 years ago

Makes sense, gulp would be overkill.