search

buildjs / rigger

Javascript file parser and include engine
http://buildjs.github.io/rigger
60 stars 15 forks source link

Add source map support #28

Open robink opened 10 years ago

robink commented 10 years ago

I believe it would be very nice to support source maps.

robink commented 10 years ago

Hey @DamonOehlman , do you think it could be feasible ? If so, I could try to take a look at it.

DamonOehlman commented 10 years ago

@robink - Sorry for the delay in getting back to you, was on a weeks holiday :)

I do think it would be possible, and it would be great if you wanted to take a crack at implementing it. Let me take a look at the code in the next couple of days and I'll provide you my thoughts about how you might go about it...

ivangretsky commented 7 years ago

Good day! Thanks for the project!

I got rigger concatenating js partials files on my gulp-based project. I got gulp-sourcemaps included in the pipeline. But in the browser dev tools I still see errors spotted only in main.js (no matter where I put sourcemaps.init(): before or after rigger().

Is this the same question? Is there any solution to this?

DamonOehlman commented 7 years ago

I think it probably is. From my reading, the gulp-sourcemaps plugin creates a sourcemap from the various packaging based on it's glob patterns. Were you using the gulp-rigger plugin?

If it was possible to use the gulp-sourcemaps package to get sourcemap support rather than trying to get rigger to do it, then that would be ideal. From having a quick look at the source though it's heavily reliant on the use of the "vinyl files" that the are emitted from the gulp.src call.

I think to get sourcemap support in rigger it would have to be manually implemented. It's one of those things I feel guilty for not doing, so I reckon I should just bite the bullet and make it work. If rigger is still useful to you in your work, then I'm more than happy to do that :)

Feel free to ping me if I go quiet...

ivangretsky commented 7 years ago

As far as I know rigger is still widely used in Russia due to this article. So some kind of source maps support will be quite nice.

olytv commented 6 years ago

I join the request! Now in order to compile js with sourcemap saving it is necessary to specify the paths in gulpfile.js. It will be more obvious if you specify paths directly in a file similar to main.js using rigger. Thanks for the project!