search

buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
113 stars 106 forks source link

Pull request tests are building on the wrong repository #176

Closed albertyw closed 3 years ago

albertyw commented 3 years ago

I've noticed that many of the currently open pull requests are failing on the last step because the build is trying to checkout the test branch from the buildkite-plugins repository rather than the forked repository. This can be most easily seen in #174 (build) and #175 (build). They have logs of the form

  | [2021-01-11T04:53:08Z] $ git clone -v -- https://github.com/buildkite-plugins/docker-buildkite-plugin.git .
...
  | [2021-01-11T04:53:08Z] # Checking out `866a6bc4b36af4af0a7b75118177092333c8b0b9`

The commit hash exists on github.com:albertyw/docker-buildkite-plugin and not on github.com:buildkite-plugins/docker-buildkite-plugin

chloeruka commented 3 years ago

Hey @albertyw – good catch! Thanks for pointing this out. I'm drafting a fix for this, I'll aim to roll it out shortly.