buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
113 stars 106 forks source link

Fix plugins (and `--entrypoint` behaviour) #208

Closed toote closed 2 years ago

toote commented 2 years ago

This fixes the 2 tests that started failing since the release of the latest plugin tester.

That uncovered a bug in the tests themselves of the --entrypoint option which is what actually caused #138. The easiest solution to which was to just remove the alternative of the plugin option to be a boolean. It needs to be a string that will be used as-is and updated the documentation accordingly.

Due to the complex interaction between entrypoint, shell and command as defined in this plugin, the docker container and the pipeline that actually used the plugin I left the reference to the issue in the documentation.