search

buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
112 stars 106 forks source link

Failure to pull docker image does not result in failed buil #109 #279

Closed thiagomata closed 2 weeks ago

thiagomata commented 1 month ago

Very similar to https://github.com/buildkite-plugins/docker-buildkite-plugin/issues/109

- label: ":docker: Isolate issue"
  key: isolate-issue
  agents:
    queue: "default"
  env:
    BUILDKIT_PROGRESS: plain
  plugins:
    - docker#v5.9.0:
        image: "this-image-do-not-exists" # intentionally asking for an image that does not exist
        always-pull: true
        mount-checkout: true
        propagate-environment: true
        privileged: true
        userns: "host"
        shell: false
        volumes:
          - "/var/run/docker.sock:/var/run/docker.sock"
          - "/root/.config/envd:/root/.config/envd"

image

Expected Behaviour

The buildkite step should fail.

Observed Behaviour

The buildkite step concludes as a success.