buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
113 stars 106 forks source link

Add a mount-checkout option #93

Closed lox closed 5 years ago

lox commented 5 years ago

In v2.0.0 we made a slightly weird change where by if you specified volumes that you wanted mounted, it would not mount the checkout directory into the container on the assumption that you would do it yourself. We also allowed a confusing value of volumes: false to disable the "default mounts", e.g the checkout directory.

This PR tries to unwind some of that complexity. Whether to mount the checkout dir into the container is determined by mount-checkout, which defaults to true. It will mount onto whatever you set for workdir. If you don't want this behaviour, you set mount-checkout to false. volumes: false is no longer a thing.