buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
172 stars 139 forks source link

Support for port in build/push repository (AKA `cache-from` separator) #364

Closed toote closed 1 year ago

toote commented 1 year ago

Adds a new option called separator-cache-from to allow for specifying a different character to split values in the cache-from stanzas.

This allows for specifying a registry with a port and not break backwards-compatibility forcing everyone to update their existing cache-from configurations.

The implementation is not perfect as there were a lot of assumptions around it due to : also being the separator for docker image tags.

Also corrected a minor annoyance with the same issue on push configurations taking the last value as being the tag instead of the 3rd element after splitting. This does mean that if a push stanza has a registry with a port it will break if you don't specify a tag (but can be easily worked around by adding :latest to the configuration so I don't think it is a big deal).

Closes #363