By default build will also push the image to remote repository

[jamesone]

Is this meant to be the default behaviour? I expect it only to push if I define the push configuration?

Here is my config:

- docker-compose#v4.11.0:
          mount-buildkite-agent: true
          image-repository: REMOTE_REPO
          image-name: base_image_branch-${FRIENDLY_BRANCH_NAME}
          build: base_image
          args:
            - NPM_TOKEN
          environment:
            - FRIENDLY_BRANCH_NAME
          cli-version: 2.2
          cache-from:
            - base_image: REMOTE_REPO:base_image_branch-${FRIENDLY_BRANCH_NAME}
          propagate-environment: true
          config:
            - docker-compose.yml

After building successfully, it goes ahead and pushes.

:docker: Pushing built images to REMOTE_REPO

I would expect it only to push if the push array is present, unless I'm missing something?

I looked at this merged PR: https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/224/files - and the code suggests that it will only push, if the push array present. Main branch still contains this same logic

[toote]

This is indeed the current behaviour and I agree that it is confusing and counter-intuitive.

Similar things also occur in other situations. For example:

• when you only specify a run option, in some conditions there will also be an attempted build
• when you specify run and push, sometimes it will be attempted to be built twice (see #309)
• when the build happens on the run and push stages, configuration options are either named differently or not used at all

We are currently thinking of changes to simplify, clarify and unify those behaviours. As it is a huge change, it will be backwards incompatible and be a major release of this plugin. We hope to have something - if time allows - in the next few months

[jamesone]

@toote thanks for the update.

RE "This is indeed the current behaviour and I agree that it is confusing and counter-intuitive."

Should we change this behaviour? I don't suspect this is a "huge" change, however, I don't know the repo. Or is this a big change and would be apart of the next major release.

[toote]

@jamesone feel free to open a PR with whatever changes you see fit. We will be more than happy to review it and iterate on it as necessary

[toote]

This change will be part of the next major release that will include #416 and #418