search

buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
172 stars 140 forks source link

SSH passed as boolean instead of string to docker-compose #382

Closed jklafka-rokt closed 1 year ago

jklafka-rokt commented 1 year ago

In #347, the plugin added support for passing --ssh to the docker-compose build command in BuildKite as a boolean option. However, docker-compose takes --ssh as a string (doc and code).

You can see this when running docker-compose locally. For example, this fails:

$ docker-compose build <project> --ssh

flag needs an argument: --ssh

Passing in default for default SSH works:

$ docker-compose build <project> --ssh default

[+] Building 5.6s (21/21) FINISHED
...
toote commented 1 year ago

Great catch! I have created PR 383 to fix the issue :)