buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
172 stars 139 forks source link

Add skip-pull support to build phase #384

Closed supaspoida closed 1 year ago

supaspoida commented 1 year ago

Reuses the existing skip-pull option to conditionally remove the --pull flag from the generated docker compose command.

I have a use case where I am pre-building images outside the docker-compose plugin and wanted to use those images in the FROM tag of a Dockerfile to be built via the plugin. With the --pull flag docker compose tries to fetch from docker hub and fails. This change puts the flag behind the same SKIP_PULL conditional currently used by the run phase.

I verified that this works as expected for my own pipelines but those are very simple at the moment and not exercising much of the plugin's surface area. If there are explicit reasons why this was unsupported previously I'm happy to revisit this approach or come up with another workaround.