search

buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
171 stars 138 forks source link

Default tty to false to minimise build output #401

Closed chendo closed 1 year ago

chendo commented 1 year ago

This PR changes the default of tty to false.

Unless there's a scenario I'm not considering, it doesn't seem to make sense to have this on by default, as CI is traditionally a non-interactive environment anyway. Most command line tools change their output behaviour to be more "interactive" when a TTY is detected, but this drastically increases build output, causing build log truncation warnings.

For a single step in our pipeline, the build output size difference is staggering!

pzeballos commented 1 year ago

Hey @chendo! thanks! I believe it's a good idea, but it would require a major release which we are planning to do in the following months to make docker compose v2 the default one. This PR will also need to update the tests 🙃 (they are currently failing)

chendo commented 1 year ago

I had a quick look at the tests but it's unclear how it works and unfortunately I won't have time to address those

pzeballos commented 1 year ago

No problem! We can work on a new PR with all the tests once we are ready for the v5 of the plugin (which should be during Q4) I'll close this one, but we'll mention you once it's ready. Thanks again! 🙏🏻