search

buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
171 stars 138 forks source link

Collapse logging of run output by default #407

Closed francoiscampbell closed 10 months ago

francoiscampbell commented 10 months ago

By default this plugin collects the run output in a +++ group, while the docker plugin collects it in a --- group (https://github.com/buildkite-plugins/docker-buildkite-plugin/blob/36b85cc317745f868f2f6918a02f9cfb6a0b3069/commands/run.sh#L503). This PR unifies the two plugins by switching to using --- by default.

The rationale for using --- by default is that when we're passing lots of environment variables, volumes, etc, the docker-compose run ... command gets pretty long and having the log group expanded by default is noisy. Additionally, it's quite likely that the command being run will create a +++ group of its own, so it's not necessary for the plugin to provide one by default.

For backwards compatibility, the collapse-run-log-group option has been added, which will restore the old behaviour.

francoiscampbell commented 10 months ago

Ok @pzeballos, I've flipped the default. Are we OK with the default being inconsistent between this plugin and the Docker one?

pzeballos commented 10 months ago

Ok @pzeballos, I've flipped the default. Are we OK with the default being inconsistent between this plugin and the Docker one?

yep, all good, they are different plugins, and we prefer not to do a backwards compatibility change at the moment :)

The build is failing in the linter step @francoiscampbell , can you update the Readme to use v4.15.0? Thanks!

francoiscampbell commented 10 months ago

Updated