search

buildkite-plugins / docker-compose-buildkite-plugin

🐳⚡️ Run build scripts, and build + push images, w/ Docker Compose
MIT License
171 stars 138 forks source link

Update Docker build args link in README.md #412

Closed MelissaKaulfuss closed 9 months ago

MelissaKaulfuss commented 9 months ago

Since the release of Docker Compose v2 the build args docs have moved. 🐳

MelissaKaulfuss commented 9 months ago

update it to use v4.16.0 ?

I'm made this suggested change via the GitHub UI's "edit" button on the file linked to from what's on main. The README references v4.15.0, is that the version referenced in my fork?

pzeballos commented 9 months ago

I'm made this suggested change via the GitHub UI's "edit" button on the file linked to from what's on main. The README references v4.15.0, is that the version referenced in my fork?

Yep! https://github.com/MelissaKaulfuss/docker-compose-buildkite-plugin/tree/patch-1 is using v4.15.0

MelissaKaulfuss commented 9 months ago

I've bumped the version in the README now, @pzeballos I was super confused, I misunderstood and thought you were saying my fork was using the wrong version number. 😆

pzeballos commented 9 months ago

Thanks @MelissaKaulfuss! :)