buildkite / agent-stack-k8s

Spin up an autoscaling stack of Buildkite Agents on Kubernetes
MIT License
77 stars 30 forks source link

Use ctx for checking cancellation of ctx #292

Closed DrJosh9000 closed 5 months ago

DrJosh9000 commented 5 months ago

I think #289 introduced some severe flakiness in the ability to just run jobs, since monitor could time out and return context.DeadlineExceeded wrapping errors without the surrounding context actually being cancelled. I think. I'm not sure.

Also I changed my mind on closing the errors channel - reading controller.go, I don't think it needs to be closed at all.