Allow extraVolumeMounts with podSpecPatch

buildkite / agent-stack-k8s

Spin up an autoscaling stack of Buildkite Agents on Kubernetes

MIT License

77 stars 27 forks source link

Allow extraVolumeMounts with podSpecPatch #327

Open bpoland opened 2 months ago

bpoland commented 2 months ago

👋 with the podSpecPatch functionality introduced in https://github.com/buildkite/agent-stack-k8s/pull/282 I'd really like to be able to specify default volumes to mount to all containers (e.g. the extraVolumeMounts available without the patching. Is this something that could be added? Maybe an extra-volume-mounts to define in the controller helm values?

I want to use this to mount an agent hooks volume as well as pipeline signing keys. Thanks!

moskyb commented 2 months ago

kia ora @bpoland! this would be a useful feature to have in the k8s stack, and we'll it to our backlog. in the meantime, we would happily accept PRs to this effect. if you want to reach out to me or @DrJosh9000 on slack, we can potentially help you out with implementation stuff, if you're interested.