search

buildkite / agent

The Buildkite Agent is an open-source toolkit written in Go for securely running build jobs on any device or network
https://buildkite.com/
MIT License
808 stars 298 forks source link

Collect timestamp lines alongside log temp file #1799

Closed agates4 closed 1 year ago

agates4 commented 2 years ago

Is your feature request related to a problem? Please describe. When the BUILDKITE_ENABLE_JOB_LOG_TMPFILE environment variable is set to true, and BUILDKITE_TIMESTAMP_LINES is also set to true, then the generated tmp file does not include the timestamp lines that we'd expect it to have.

Describe the solution you'd like I would like the log tmpfile to have the timestamp lines that we'd also see normally in the UI output.

Describe alternatives you've considered Actually, using the curl api DOES include the timestamp lines.

Additional context This would be great so that we can upload and associate logs with our Datadog CI/CD pipelines!

agates4 commented 2 years ago

BTW I think #758 is complete

triarius commented 2 years ago

Hey we agree this should be fixed. We'll attempt to get to it but can't guarantee a time-frame. In the mean time, any pull request would be welcome.

triarius commented 1 year ago

We are now tracking this internally in our backlog. As always, PRs are welcome.