search

buildkite / docker-buildkite-agent

Previous home of buildkite/agent docker image scripts
26 stars 14 forks source link

Switch to standard Ubuntu packages #11

Closed toolmantim closed 8 years ago

toolmantim commented 8 years ago

@lox @lachie this changes the Ubuntu packages to just use the standard Buildkite installer, but changes the paths to be /buildkite. I've copied the bootstrap.sh to the right path in case someone was depending on it.

Also in version 2.2 of the buildkite-agent there'll be no bootstrap.sh, it'll be completely self-contained

I'm a heads up @lachie, I'm changing the ubuntu-beta beta tag name to beta-ubuntu… but I'll leave the old one there.

It also adds an image for experimental (master) builds of the agent… because I want to test some stuff :)

keithpitt commented 8 years ago

Looks good to me! :+1:

toolmantim commented 8 years ago

Not all the images build just yet though, because our apt repos are broked atm. Once that's good then all the tests will pass and we can :rocket: and give it a go on ECS! :tada:

toolmantim commented 8 years ago

So @lox just pointed out there are official dind images we could base this off: https://hub.docker.com/_/docker/

I'll update this PR to switch the dind images to those instead, but we're gonna have to drop the images for experimental builds, because we only publish them as apt and yum repos at the moment and we can't use them from the alpine-based images.

lachie commented 8 years ago

thanks for the heads up :crown: :sheep::fork_and_knife:

lox commented 8 years ago

What's the motivation to swapping to the ubuntu packages?

toolmantim commented 8 years ago

The motivation was to just make it more alike to what people will be installing naked, or what they'd do in their own image. But given the new version of the agent requires no other files than the binary itself, and all config should really be done via ENV vars, I'm thinking I ditch this PR. I'll pull in the rest scripts, and add an experimental image that simply grabs the binary from github.

toolmantim commented 8 years ago

Closing, as we've redone most of this in master anyhoot.