search

buildkite / docker-buildkite-agent

Previous home of buildkite/agent docker image scripts
26 stars 14 forks source link

Download assets before build #20

Closed lox closed 8 years ago

lox commented 8 years ago

To ensure that builds use the lastest versions of releases this downloads assets first and copies them into the Docker build, ensuring layer cache doesn't miss subsequent versions.

toolmantim commented 8 years ago

Noice! :+1:

lox commented 8 years ago

I'm by no means proud of that download.sh :/

Think it's a bad idea to avoid using the bash installer you guys provide @toolmantim?

toolmantim commented 8 years ago

Hmm not sure. @keithpitt?

lox commented 8 years ago

It looked to me like most of the stuff in there was to deal with people installing into different environments. Into a docker container is a pretty controlled install.

keithpitt commented 8 years ago

I think it's fine using the installer - that's what it's there for!

keithpitt commented 8 years ago

(And I have no plan on getting rid of it any time soon)

lox commented 8 years ago

Sorry, we meant is it ok to NOT use it?

lox commented 8 years ago

This script does the look up from https://buildkite.com/agent/releases/latest directly.

keithpitt commented 8 years ago

Oh right! Yeah, that's cool too! :) Sorry, I totally misread that. Do what evs :)