search

buildkite / docker-buildkite-agent

Previous home of buildkite/agent docker image scripts
26 stars 14 forks source link

Fix Kubernetes 1.7 compatibility. #60

Closed fotinakis closed 7 years ago

fotinakis commented 7 years ago

Add libc6-compat to Alpine-based image.

This fixes a surprising No such file or directory error when running certain binaries that do actually exist in the container. In particular, if you running buildkite-docker in Docker/Kubernetes privileged: true mode (so that it can spawn child docker containers) and you're mounting the /usr/bin/docker binary from the host (as recommended by the Buildkite docs), you will get a No such file or directory error and the build will die because it cannot execute the mounted docker binary from within the buildkite agent container. Adding libc6-compat fixes this.

These seems to affect Kubernetes >1.7, in both the buildkite-agent v2 and v3.

toolmantim commented 7 years ago

Ugh, sorry you've had problems there.

We never added this back in the day in an effort to keep things minimal, but it's caused a few problems now and I think it's probably a good addition to the image… especially in the cases of linking in the Docker binary for k8s.

Thanks for taking the time to submit the pull request! 🙏🏼