search

buildkite / docker-buildkite-agent

Previous home of buildkite/agent docker image scripts
26 stars 14 forks source link

Without a global gitconfig file git-credential auth doesn't work #62

Open lox opened 6 years ago

lox commented 6 years ago

A global git config seems to be required to use git-credential authentication:

[credential]
helper = store
shaneog commented 6 years ago

This is handled automatically by the hyper-buildkite-agent.

The command git config --global credential.helper "store" is needed, with or without the --file argument.

shaneog commented 6 years ago

Although the command is shown in the README in this repo, that doesn't help when the git-credentials file is mounted by Kubernetes. In this case it would be great to have the entrypoint configure the credential store, as with the hyper fork. Mounting an environment hook in Kubernetes is the same as just mounting a global gitconfig, and feels a little extraneous.

The documentation for GKE should also be updated here: https://buildkite.com/docs/agent/gcloud#running-the-agent-on-google-container-engine