search

buildkite / elastic-ci-stack-for-aws

An auto-scaling cluster of build agents running in your own AWS VPC
https://buildkite.com/docs/quickstart/elastic-ci-stack-aws
MIT License
418 stars 272 forks source link

Allow syncing cloudformation stack using git sync #1264

Open nitrocode opened 10 months ago

nitrocode commented 10 months ago

Is your feature request related to a problem? Please describe. I want to sync the cf template using git

Describe the solution you'd like Git sync

https://aws.amazon.com/about-aws/whats-new/2023/11/aws-cloudformation-git-management-stacks/

Describe alternatives you've considered Keep using s3

Additional context n/a

triarius commented 10 months ago

@nitrocode thanks, this is a very good suggestion. We are going to log an internal feature request for this. It would help move it also immensely if you can write a few words about the capabilities the git sync feature will unlock for you.

triarius commented 10 months ago

@nitrocode I've had a closer look at how the Git Sync would work. It seems that both the template and the Stack deployment file need to live in the same repository. While we can publish the template to a git repository, the Stack deployment file contains the parameter values, so it's something each customer will need an independent version of.

I think if you want to use it, you'll have to create a repository that contains both the template and your deployment file. To keep the template updated, you may have luck using an automation like Renovate.

But I think Git Sync as it is currently implemented is not useable with public CloudFormation templates like the Elastic CI Stack.

Let me know if I've missed something, though.

nitrocode commented 10 months ago

Ah ok. Thank you for considering it then. I was hoping for an easier way to keep buildkite stacks in sync. We'll keep using our terraform approach for now using the s3 link which works well enough.