search

buildkite / elastic-ci-stack-for-aws

An auto-scaling cluster of build agents running in your own AWS VPC
https://buildkite.com/docs/quickstart/elastic-ci-stack-aws
MIT License
417 stars 275 forks source link

Update the default queue name to match what's provisioned in a new org #1380

Closed amu-g closed 1 month ago

amu-g commented 1 month ago

By default, a new Buildkite org will have one cluster called Default, with a queue named default-queue. This PR updates the elastic ci stack default to match so that we get agents registered with the default queue out of the box.

This might be a breaking change for any orgs that have a queue named default that deploy the elastic stack without supplying a value for BuildkiteQueue.

steveh commented 1 month ago

related: https://linear.app/buildkite/issue/PIP-1198/default-queue-key-doesnt-match-queue-key-in-elastic-stack-default and https://linear.app/buildkite/issue/PIP-1209/the-default-queue-for-elastic-ci-aws-doesnt-match-the-default-queue-we

DrJosh9000 commented 1 month ago

This seems fine to me, but I'm curious how this PR compares with changing the default cluster's default queue name to be default instead?

amu-g commented 1 month ago

Closing this in favour of changing on the application side