buildkite / elastic-ci-stack-for-aws

An auto-scaling cluster of build agents running in your own AWS VPC
https://buildkite.com/docs/quickstart/elastic-ci-stack-aws
MIT License
416 stars 268 forks source link

Check for blank submodules in AMI builds #509

Open jmeickle opened 5 years ago

jmeickle commented 5 years ago

I'm currently attempting to build a new AMI to unlock some buildkit fixes in a Docker RC. The README doesn't mention that plugins are installed as submodules, and the AMI build doesn't actually fail if the submodules are blank. Instead you get blank folders installed onto the instance, which results in a very confusing runtime experience. It's worth at least adding a README note to the packer build section, since not all git clients will automatically init submodules.

lox commented 5 years ago

I'm sorry you had a hard time with this!

It's tricky trying to defensively write some of these scripts for folks that fork the AMI building without adding a lot of code.

Perhaps adding the plugins to the goss tests would catch things like this? Would happily accept a PR.