search

buildkite / elastic-ci-stack-for-ec2-mac

CloudFormation template for Auto Scaling AWS EC2 Mac based Buildkite Agents
MIT License
9 stars 5 forks source link

Add BuildkiteAgentTokenParameterStorePath #10

Closed scadu closed 6 months ago

scadu commented 2 years ago

Closes #8

scadu commented 1 year ago

@moskyb thanks for the feedback! Indeed, now I see I missed a lot and it won't work automagically. I marked PR as a draft now and I'll add the missing pieces in upcoming days.

moskyb commented 1 year ago

it won't work automagically

unfortunately! my job would be a heck of a lot easier....

anyway, lemme know if you run into any problems, happy to help out :)

scadu commented 1 year ago

@moskyb, not sure what I was thinking either when I created a PR with this change only. I'm working on adding the required items: IAM role and policy, a script to inject the agent token after agent installation, etc.

triarius commented 1 year ago

Apologies @scadu, I just merged another community contributed PR that caused some merge conflicts with yours. It should be a somewhat straight forward fix, though. Let us know if that's not the case though and we can take a look.

scadu commented 6 months ago

Closing it for now as I don't plan to work on it now, and it's been a year already.