Add support for overriding the endpoint URL

buildkite / elastic-ci-stack-s3-secrets-hooks

🕵️‍♀️ Expose secrets to your buildkite build steps via Amazon S3

MIT License

24 stars 17 forks source link

Add support for overriding the endpoint URL #19

Closed bromanko closed 4 years ago

bromanko commented 6 years ago

Google Cloud has a storage API which is compatible with Amazon S3. In order to use it, you must pass an --endpoint-url parameter in requests to point them at Google.

This PR allows for overriding the --endpoint-url via a AWS_ENDPOINT_URL environment variable. This allows us to use the same plugin for Google Cloud Storage.

lox commented 6 years ago

Apologies @bromanko somehow I completely missed this! My concern with trying to add Google Cloud support is that it makes it harder to iterate on this stuff, for instance adding support for Secrets Manager. Thoughts on cloning this to elastic-ci-stack-gc-secrets or similar?

bromanko commented 6 years ago

No worries. I've just been using my fork. Creating a new clone makes sense. Are you suggesting creating one under the buildkite namespace, or would you prefer I create it?

toolmantim commented 4 years ago

Sorry we didn't reply earlier @bromanko — best to do it on your own fork! I'll close this one for now.