buildkite / elastic-ci-stack-s3-secrets-hooks

🕵️‍♀️ Expose secrets to your buildkite build steps via Amazon S3
MIT License
24 stars 17 forks source link

Add Secrets Manager support #21

Closed holmesjr closed 6 years ago

holmesjr commented 6 years ago

As per the discussion here: https://buildkite-community.slack.com/archives/C19BG77H9/p1532598572000110

I propose either changing this plugin to do both S3 and SM based secrets, or alternatively create a new plugin that just does SM and add it to the elastic stack.

At least Seek has done some of the work: https://github.com/seek-oss/aws-sm-buildkite-plugin, but the file-based work in that plugin all runs post-checkout and I want to secure git-credentials with SM (i.e. pre-checkout).

holmesjr commented 6 years ago

As per discussion around https://github.com/buildkite/elastic-ci-stack-for-aws/issues/460https://github.com/buildkite/elastic-ci-stack-for-aws/issues/460 a separate plugin makes more sense. Closing the issue here.