search

buildkite / elastic-ci-stack-s3-secrets-hooks

🕵️‍♀️ Expose secrets to your buildkite build steps via Amazon S3
MIT License
24 stars 17 forks source link

Fix unbound AWS_DEFAULT_REGION in git credential helper #25

Closed stevehodgkiss closed 5 years ago

stevehodgkiss commented 5 years ago

L58 references an unbound variable AWS_DEFAULT_REGION and with -u set this breaks the script.

$ /usr/local/buildkite-aws-stack/plugins/secrets/git-credential-s3-secrets my-bucket my-pipeline/git-credentials
/usr/local/buildkite-aws-stack/plugins/secrets/git-credential-s3-secrets: line 58: AWS_DEFAULT_REGION: unbound variable

git-credentials is working for me with this change.

stevehodgkiss commented 5 years ago

As discussed on Slack, an error message rather than a default would be a better solution.