search

buildkite / elastic-ci-stack-s3-secrets-hooks

🕵️‍♀️ Expose secrets to your buildkite build steps via Amazon S3
MIT License
24 stars 17 forks source link

Use current region to find bucket region #38

Closed keithduncan closed 3 years ago

keithduncan commented 3 years ago

Fixes https://github.com/buildkite/elastic-ci-stack-for-aws/issues/828

yob commented 3 years ago

I haven't compiled and tested this, but the diff looks straightforward and unsurprising :+1:

Once we've confirmed the fix works (by booting a test stack?), can we tag a 2.something (is this a feature or a bugfix? :thinking:) and use the tag in the elastic stack submodule?

keithduncan commented 3 years ago

Confirmed with https://github.com/buildkite/elastic-ci-stack-for-aws/pull/875 that this change works

yob commented 3 years ago

:tada: