search

buildkite / elastic-ci-stack-s3-secrets-hooks

🕵️‍♀️ Expose secrets to your buildkite build steps via Amazon S3
MIT License
24 stars 17 forks source link

Fix git-credential-s3-secrets to discover correct bucket region #45

Closed keithduncan closed 3 years ago

keithduncan commented 3 years ago

This should use aws s3api get-bucket-location to find the bucket location rather than using AWS_DEFAULT_REGION.

keithduncan commented 3 years ago

This should follow the same region finding procedure as the s3-secrets binary https://github.com/buildkite/elastic-ci-stack-s3-secrets-hooks/blob/922b375a124b6620bdac362341b107dc56bdb8f8/s3secrets-helper/s3/s3.go#L30-L49