Different colour for jobs that did not run with wait step

[eredi93]

when you use a wait step and a job fails all the jobs after the wait step becomes red, the sam colour of the failed test. it is missing the x that identifies the failed job but to many people, it is quite confusing as it has the same colour of the failed job. would be better to have a different colour that makes it easier to understand what failed. I propose grey.

example form the slack discussion https://buildkitechat.slack.com/archives/support/p1489598831619588:

[keithpitt]

Ah, yeah this is good feedback! It's definitely not the first time we've been tripped up on this :)

Maybe for subsequent steps that aren't run, perhaps they should be a light grey red or something? What do you think @toolmantim?

[toolmantim]

That's really good feedback, thanks @eredi93! I think grey for anything that hasn't run makes the most sense. We'll look at getting this changed for you.

[ticky]

Pasting chat log here;

----- March 15th ----- matt [10:27 AM]
So, I was under the impression that a “wait” step waited until all previous steps had passed, before continuing, but it seems it continues even if some preceding steps fail…?>

[10:27]
Shared with CloudApp Image 2017-03-15 at 5.26.25 pm.png (92kB)>

Jacopo Scrinzi [10:42 AM]
if you look at the jobs after the wait step they did not actually run. if a job fails any job after the wait command will be red>

matt [10:42 AM]
ohhhh>

[10:42]
derp>

[10:42]
thanks that makes sense>

Jacopo Scrinzi [10:43 AM]
i know is kinda confusing, that should probably be a different colour from the failed command>

matt [10:43 AM]
I guess that’s why there’s no cross>

Jacopo Scrinzi [10:43 AM]
@keithpitt possible feature request?>

[10:44]
it is confusing if you are new to buildkite, i see my colleges come with the same question

[eredi93]

@ticky is this now fixed? why did you close it?

[ticky]

because I referenced it in a particular commit… :wink:

[ticky]

It’s live! :sparkles: