search

buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

'BUILDKITE_PULL_REQUEST_BASE_BRANCH' when changing base branch on PR #306

Closed joanromano closed 5 years ago

joanromano commented 6 years ago

This environment variable does not get updated if the PR's base branch is changed after creating the PR.

Even after the change, checking for ENV['BUILDKITE_PULL_REQUEST_BASE_BRANCH'] will basically output the same branch name as before.

rezamorav commented 6 years ago

is there any update on this issue? we are really keen to get this issue fixed.

whenever the base branch is merge and/or deleted and we change the PR, the BUILDKITE_PULL_REQUEST_BASE_BRANCH should be updated. Otherwise we have to delete the existing PR and creating a new one.

karina-clio commented 6 years ago

hitting this one right now. has there been any progress? we are trying to move our development efforts into smaller PRs for review and this would greatly hinder that process.

Drew-Goddyn commented 6 years ago

hitting this issue repeatedly this week :(

keithpitt commented 5 years ago

Sorry for the slow response on this one folks. I just wanted to give you a quick heads up that we keep BUILDKITE_PULL_REQUEST_BASE_BRANCH in sync with GitHub pull requests now. If you change the base in a pull request, the next build that triggers will have the latest value.

Let me know if you have any follow up questions! (and sorry again for taking a while to get the fix out)