buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

GET /builds doesn't return all retried jobs #346

Closed gtirloni closed 6 years ago

gtirloni commented 6 years ago

This URL will return a list of all jobs in the build, including retried jobs (stored in store variable) :

https://buildkite.com/fluid-project/fluid-infusion/builds/191

This URL will only return one instance of each job, which doesn't include multiple retries:

https://api.buildkite.com/v2/organizations/fluid-project/pipelines/fluid-infusion/builds/191
sj26 commented 6 years ago

Hi @gtirloni — sorry about that, we didn't want to change the API too much when we first released retries. I've just added a parameter so you can ask these endpoints to include retried jobs:

https://api.buildkite.com/v2/organizations/fluid-project/pipelines/fluid-infusion/builds/191?include_retried_jobs=true

Jobs should have two new properties — retried: true/false and retried_in_job_id: null/"UUID" — which indicates whether that job has been retried, and the id of the job it is retried in. The referenced job should have a retries_count one higher than the retried job. We'll update the docs soon.

gtirloni commented 6 years ago

@sj26 that was super fast, thanks a lot!

mwean commented 6 years ago

Thank you!! 🎉