search

buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

Buildkite agent docker image for alpine linux broken #364

Closed rjhazelwood closed 6 years ago

rjhazelwood commented 6 years ago

The latest version buildkite/agent:3 (3.1.1) doesn't start up because tini is missing.

toolmantim commented 6 years ago

Sorry @rjhazelwood — we're getting this fixed now.

toolmantim commented 6 years ago

Ok, fixed images are up and that should be working as expected again.

$ docker pull buildkite/agent
Using default tag: latest
latest: Pulling from buildkite/agent
Digest: sha256:1e9fefd4b9575c8d12d4e994583a84e240790160a36f84cfad57f563845ce44b
Status: Image is up to date for buildkite/agent:latest
$ docker run --rm buildkite/agent --version
buildkite-agent version 3.1.1, build 2376

It appears we removed tini (in buildkite/agent#749) but the tests override the default custom entrypoint, resulting in the tests incorrectly passing and sending it live without a working entrypoint.

We've fixed pushed new images, fixed master, and will investigate fixing the tests too.

Sorry again for this. And let me know if it's all working good for you now.