search

buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

[skip ci] at Pull Request Level #432

Open jmendiara opened 5 years ago

jmendiara commented 5 years ago

It would be nice to include support [skip ci] at Pull Request level.

This will help on PR workflows[1] like this one:

But... Sometimes devs are looking just for some feedback, making a WIP (work in progress) pull request, or they are updating some doc that will not change binaries...

Running a pipeline for this cases is money wasting, in terms of CI resources and developer time.

The current alternatives is squash & rebase, ammending the message to include [skip ci] at commit level. But manual rebasing is hard sometimes and github can make this for you when merging.

Analyzing [skip ci] labels in PRs, or in PR title/description as you do with commits, will make CI run smoother, saving some $$

[1] You can make a Pull Request only pipeline by limiting to build a very strange branch

captura de pantalla 2018-07-21 a las 8 33 56
petemounce commented 5 years ago

How about for branches like this, naming them wip/some-name-here, and then setting up buildkite with !wip/* so it doesn't build such branches or PRs?

jmendiara commented 5 years ago

@petemounce That could be a workaround, but it requires another contract in the way of working for devs that will require to push to another remote branch when done.

It's easier to add/remove labels, and pass the CI when no-label is present.

petemounce commented 5 years ago

That's true. It's quite a provider-specific way to do it, though - each provider would need to have some labelling mechanism, and each integration would need to grow to support it.

davehowell commented 3 years ago

But... Sometimes devs are looking just for some feedback, making a WIP (work in progress) pull request, or they are updating some doc that will not change binaries...

For those specific scenarios, you could just make it not trigger a build if the PR has the "Draft" or "WIP" setting on it. Github, Gitlab and Bitbucket all have that option natively.

chloeruka commented 3 years ago

Thanks @davehowell

We do have an upcoming conditional webhook feature that should give pipeline maintainers extra control over how and when builds are made. Keep an eye on our changelog. 😃