search

buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

Pipeline in PR Close #433

Open jmendiara opened 6 years ago

jmendiara commented 6 years ago

Use Case:

  1. Devs create the Pull Request with number 512
  2. CI launches a Pull Request pipeline[1]
  3. A new deployment is created, for example (https://pr512.dev.example.com)
  4. Some automated e2e testing is done
  5. Devs connect to the environment and make manual testing (very common when developing UI)
  6. Devs pushes more commits. Goto 2.
  7. Changeset is accepted and the PR is merged
  8. https://pr512.dev.example.com is undeployed

To make this happen you need to listen to github webhooks by your own and trigger pipelines via api.

It would be nice to have buildkite native support for this.

[1] Pull Request pipeline understood as something only runs in PR, configured this way

captura de pantalla 2018-07-21 a las 8 33 56
petemounce commented 6 years ago

I'm not sure I've parsed this correctly, but I think you're asking for the ability to run a pipeline, or steps, when a PR is merged. I'd definitely find that useful - I'd use it to

at the least.

jmendiara commented 6 years ago

Yep, not only on PR merge, but PR close (that is, when merged or discarded)

jdotjdot commented 6 years ago

We'd use this too. Currently we make this happen by having another microservice receive Github webhooks, watch out for PR merges, and then manually call a Buildkite pipeline to discard old review environments. I'd rather it be part of Buildkite directly, obviously.

miles- commented 5 years ago

This is something that would be useful for us as well. We are planning to implement this with a cloud function that listens for pull request events and triggers the pipeline API for close events, but it'd be nicer to have this built directly into Buildkite.

williamcodes commented 3 years ago

I'd like this feature for deleting branch preview environments. IS this still a live issue?

zeele commented 3 years ago

+1

bluemalkin commented 2 years ago

Any update on this ? I am forced to use github actions to call the BK api to trigger an undeploy pipeline.

s33dunda commented 2 years ago

Yes please. Don't force me into the arms of GHA. :D

andrewdrob10 commented 2 years ago

Just wondering how this is not a feature already?

As a workaround, we are using GitHub Actions to trigger a BuildKite pipeline to clean up our cloud infrastructure that is deployed using BuildKite? Seems a bit of a backwards approach to cleaning up on a closed event. Is there anything on the roadmap for this?