buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

Allow trigger steps to be skipped #437

Closed nullobject closed 5 years ago

nullobject commented 5 years ago

It would be great if trigger steps could be skipped just like with command steps. i.e. Setting the skip value to true would skip that step.

Instead I get the error:

Failed to upload and process pipeline: POST https://agent.buildkite.com/v3/jobs/dbebef68-98b3-49ab-9cae-443cac231772/pipelines: 422 `skip` is not a valid property on the `build` configuration on a `trigger` step. Please check the documentation to get a full list of supported properties.
keithpitt commented 5 years ago

@nullobject it should be supported! If you pull the skip attribute up one level, to be this:

- trigger: "my-pipeline"
  skip: true
  build:
    ...

Then I think it should work... Based on the error you posted, I think you may have this:

- trigger: "my-pipeline"
  build:
    skip: true
nullobject commented 5 years ago

Ah, good catch. Sorry for the false alarm 😊