buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

Job kill timeout should be configurable #464

Closed DazWorrall closed 6 years ago

DazWorrall commented 6 years ago

It's currently hardcoded to 10 seconds:

https://github.com/buildkite/agent/blob/c9645249f076beef3cebce34dc9980fe8c54d502/process/process.go#L314-L319

We have some cases where it's really not unusual for a graceful shutdown to take longer than that, so it would be useful to be able to configure this - per job would be ideal, but as an agent option would be a step forward.

cc @lox

lox commented 6 years ago

There is an issue over at https://github.com/buildkite/agent/pull/700 with some context @DazWorrall

DazWorrall commented 6 years ago

Perfect, I'll subscribe to that 👍