search

buildkite / feedback

Got feedback? Please let us know!
https://buildkite.com
25 stars 24 forks source link

Allow custom build cancel grace period #489

Closed eredi93 closed 5 years ago

eredi93 commented 6 years ago

We use Buildkite to execute our Terraform commands and if a teammate clicks the Cancel button (by mistake or without knowing the consequences) out pipeline gets into a broken state. Terraform needs quite some time to clean-up and release the Dynamo Lock.

When Terraform does not stop gracefully the Lock is not being removed and the pipeline is in a broken state, blocking all new builds. At that point someone from the team that owns the pipeline needs to manually remove the lock - creating some toil for the team.

I have been following https://github.com/buildkite/agent/pull/700 but i'd be great to know if there is a hack in the meantime, i guess https://github.com/buildkite/feedback/issues/362 could help with my problem.

lox commented 5 years ago

How would you feel about us just changing the default to 2 minutes?

eredi93 commented 5 years ago

@lox thanks for looking at this! 2min is a bit better and cover i'd say most cases. if you can get this out soonish i'll take it but for some use cases terraform may take more time to clean itself up. the perfect solution to this would be to have it configurable. getting https://github.com/buildkite/agent/pull/700#issuecomment-446092978 in would be 👌

lox commented 5 years ago

I think we've figured out something better. Will update you shortly!

lox commented 5 years ago

This is now live in Agent v3.7.0!