buildkite / frontend

🌏 The front-end application code for https://buildkite.com
MIT License
137 stars 27 forks source link

Make sure HMR always works #713

Closed sj26 closed 5 years ago

sj26 commented 5 years ago

Webpack dev server seems to serve slightly different assets to what are compiled by messing with them in middleware, and it needs to talk directly to its own host because it uses socket io or something to do websocket-y hot module reloading. So make sure it always spits out a manifest with a fully-qualified public path.

This should fix some hot-reloading behaviour seen in dev while also still allowing us to build or download frontend assets for local use instead.