buildkite / frontend

🌏 The front-end application code for https://buildkite.com
MIT License
137 stars 27 forks source link

Add centrifuge in parallel with pusher #755

Closed sj26 closed 5 years ago

sj26 commented 5 years ago

This gives us the ability to switch on a centrifuge client instead of pusher, if configured. It should have zero impact unless window._centrifugo is set.

I'm very aware that this doesn't move us to a better push infrastructure throughout the frontend, it's just a straight swap to get us away from Pusher. Once we're not bound by pricing constraints we'll be able split things up and use pubsub more effectively.

I'm a little worried about the bundle size bloat given all the protobuf stuff which we probably won't use. I wonder if there's a way to push a fix upstream to make it easier to optimise that stuff out.