search

buildkite / frontend

🌏 The front-end application code for https://buildkite.com
MIT License
137 stars 27 forks source link

Remove nested animation-spin in the spinner #764

Closed toolmantim closed 5 years ago

toolmantim commented 5 years ago

Looks like we have a double animation happening inside our spinner, which goes against the performance comment at the top of the file. This removes the nested animation-spin and fixes up the other uses of the class to work with the new values.

toolmantim commented 5 years ago

It'd be nice to roll out this optimisation (pushing the animation to outside the svg element) to the BuildState icon too…

toolmantim commented 5 years ago

I think this is good to go!